-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
webhook tls min version to tls_v1.2 #1225
Comments
Before add this, the controller-runtime has to be updated to v0.13.1 depends on #1221 |
Now we rely on the manager to create the default webhook server. The #1221 has been merged. Do you know if the default server will set TLS to 1.2? opentelemetry-operator/main.go Line 154 in 7ce297d
// WebhookServer is an externally configured webhook.Server. By default,
// a Manager will create a default server using Port, Host, and CertDir;
// if this is set, the Manager will use this server instead.
WebhookServer *webhook.Server |
i think we can update TLS config through this https://github.com/kubernetes-sigs/controller-runtime/blob/master/pkg/manager/manager.go#L253 first using crypto/tls lib
This is my initial idea, need to be test and verify. And i need some help to understand the build and debug of opentelemetry-operator on local. |
…lemetry#1230) * fix min tls setting for webhook server (open-telemetry#1225) * using constant as setting * fix godot issue on comment
Currently the webhook on controller-manager is operate on port 9443. The webhook server of the https://github.com/kubernetes-sigs/controller-runtime/blob/master/pkg/webhook/server.go#L77 is configurable
Is there any plan to support setting to use min tls v1.2 as open telemetry collector of v0.59.0? and
TLS 1.0 and 1.1 are deprecated due to known vulnerabilities and should be avoided.
The text was updated successfully, but these errors were encountered: