Skip to content

Commit

Permalink
[autoinstrumentation] Bump go auto instrumentation to 0.8.0-alpha (#2358
Browse files Browse the repository at this point in the history
)

* Bump go auto instrumentation to 0.8.0-alpha

* Changelog

* Update readme
  • Loading branch information
TylerHelmuth authored Nov 16, 2023
1 parent 49a29ce commit ff4ffa6
Show file tree
Hide file tree
Showing 9 changed files with 25 additions and 28 deletions.
16 changes: 16 additions & 0 deletions .chloggen/bump-go-instrumentation-version.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
change_type: breaking

# The name of the component, or a single word describing the area of concern, (e.g. operator, target allocator, github action)
component: autoinstrumentation

# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
note: Bump Go auto instrumentation version to v0.8.0-alpha

# One or more tracking issues related to the change
issues: [2358]

# (Optional) One or more lines of additional information to render under the primary note.
# These lines will be padded with 2 spaces and then inserted directly into the document.
# Use pipe (|) for multiline entries.
subtext: The default export protocol was switched from `grpc` to `http/proto`
10 changes: 7 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,13 @@ spec:
# See https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation/blob/888e2cd216c77d12e56b54ee91dafbc4e7452a52/docs/config.md#otlp
- name: OTEL_EXPORTER_OTLP_ENDPOINT
value: http://otel-collector:4318
go:
env:
# Required if endpoint is set to 4317.
# Go autoinstrumentation uses http/proto by default
# so data must be sent to 4318 instead of 4317.
- name: OTEL_EXPORTER_OTLP_ENDPOINT
value: http://otel-collector:4318
EOF
```

Expand Down Expand Up @@ -279,9 +286,6 @@ Go auto-instrumentation also requires elevated permissions. The below permission

```yaml
securityContext:
capabilities:
add:
- SYS_PTRACE
privileged: true
runAsUser: 0
```
Expand Down
3 changes: 0 additions & 3 deletions pkg/instrumentation/golang.go
Original file line number Diff line number Diff line change
Expand Up @@ -61,9 +61,6 @@ func injectGoSDK(goSpec v1alpha1.Go, pod corev1.Pod) (corev1.Pod, error) {
SecurityContext: &corev1.SecurityContext{
RunAsUser: &zero,
Privileged: &true,
Capabilities: &corev1.Capabilities{
Add: []corev1.Capability{"SYS_PTRACE"},
},
},
VolumeMounts: []corev1.VolumeMount{
{
Expand Down
9 changes: 0 additions & 9 deletions pkg/instrumentation/golang_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -136,9 +136,6 @@ func TestInjectGoSDK(t *testing.T) {
SecurityContext: &corev1.SecurityContext{
RunAsUser: &zero,
Privileged: &true,
Capabilities: &corev1.Capabilities{
Add: []corev1.Capability{"SYS_PTRACE"},
},
},
VolumeMounts: []corev1.VolumeMount{
{
Expand Down Expand Up @@ -200,9 +197,6 @@ func TestInjectGoSDK(t *testing.T) {
SecurityContext: &corev1.SecurityContext{
RunAsUser: &zero,
Privileged: &true,
Capabilities: &corev1.Capabilities{
Add: []corev1.Capability{"SYS_PTRACE"},
},
},
VolumeMounts: []corev1.VolumeMount{
{
Expand Down Expand Up @@ -257,9 +251,6 @@ func TestInjectGoSDK(t *testing.T) {
SecurityContext: &corev1.SecurityContext{
RunAsUser: &zero,
Privileged: &true,
Capabilities: &corev1.Capabilities{
Add: []corev1.Capability{"SYS_PTRACE"},
},
},
VolumeMounts: []corev1.VolumeMount{
{
Expand Down
3 changes: 0 additions & 3 deletions pkg/instrumentation/podmutator_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -2434,9 +2434,6 @@ func TestMutatePod(t *testing.T) {
SecurityContext: &corev1.SecurityContext{
RunAsUser: &zero,
Privileged: &true,
Capabilities: &corev1.Capabilities{
Add: []corev1.Capability{"SYS_PTRACE"},
},
},
VolumeMounts: []corev1.VolumeMount{
{
Expand Down
6 changes: 0 additions & 6 deletions pkg/instrumentation/sdk_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1058,9 +1058,6 @@ func TestInjectGo(t *testing.T) {
SecurityContext: &corev1.SecurityContext{
RunAsUser: &zero,
Privileged: &true,
Capabilities: &corev1.Capabilities{
Add: []corev1.Capability{"SYS_PTRACE"},
},
},
VolumeMounts: []corev1.VolumeMount{
{
Expand Down Expand Up @@ -1162,9 +1159,6 @@ func TestInjectGo(t *testing.T) {
SecurityContext: &corev1.SecurityContext{
RunAsUser: &zero,
Privileged: &true,
Capabilities: &corev1.Capabilities{
Add: []corev1.Capability{"SYS_PTRACE"},
},
},
VolumeMounts: []corev1.VolumeMount{
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ spec:
requests:
cpu: "50m"
memory: "32Mi"
image: ghcr.io/open-telemetry/opentelemetry-go-instrumentation/autoinstrumentation-go:v0.7.0-alpha
image: ghcr.io/open-telemetry/opentelemetry-go-instrumentation/autoinstrumentation-go:v0.8.0-alpha
env:
- name: OTEL_GO_AUTO_TARGET_EXE
value: /usr/src/app/productcatalogservice
Expand Down
2 changes: 0 additions & 2 deletions tests/e2e-instrumentation/instrumentation-go/scc.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,6 @@ metadata:
allowHostDirVolumePlugin: true
allowPrivilegeEscalation: true
allowPrivilegedContainer: true
allowedCapabilities:
- 'SYS_PTRACE'
fsGroup:
type: RunAsAny
runAsUser:
Expand Down
2 changes: 1 addition & 1 deletion versions.txt
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ autoinstrumentation-python=0.41b0
autoinstrumentation-dotnet=1.1.0

# Represents the current release of Go instrumentation.
autoinstrumentation-go=v0.7.0-alpha
autoinstrumentation-go=v0.8.0-alpha

# Represents the current release of Apache HTTPD instrumentation.
# Should match autoinstrumentation/apache-httpd/version.txt
Expand Down

0 comments on commit ff4ffa6

Please sign in to comment.