Copy desired Service ports when reconciling

open-telemetry · May 27, 2021 · c369568 · c369568
1 parent 2ba1557
commit c369568
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/pkg/collector/reconcile/service.go b/pkg/collector/reconcile/service.go
@@ -194,6 +194,7 @@ func expectedServices(ctx context.Context, params Params, expected []corev1.Serv
 		for k, v := range desired.ObjectMeta.Labels {
 			updated.ObjectMeta.Labels[k] = v
 		}
+		updated.Spec.Ports = desired.Spec.Ports
 
 		patch := client.MergeFrom(existing)
 

diff --git a/pkg/collector/reconcile/service_test.go b/pkg/collector/reconcile/service_test.go
@@ -160,9 +160,7 @@ func TestExpectedServices(t *testing.T) {
 		assert.NoError(t, err)
 		assert.True(t, exists)
 		assert.Equal(t, instanceUID, actual.OwnerReferences[0].UID)
-		// issue# https://github.com/open-telemetry/opentelemetry-operator/issues/256
-		// Would uncomment once above issue is resolved
-		//assert.Contains(t, actual.Spec.Ports, extraPorts)
+		assert.Contains(t, actual.Spec.Ports, extraPorts)
 
 	})
 }