revert to not use getParams

open-telemetry · Aug 29, 2024 · b6f0911 · b6f0911
1 parent 5dcfa35
commit b6f0911
Showing 1 changed file with 9 additions and 6 deletions.
diff --git a/controllers/opentelemetrycollector_controller.go b/controllers/opentelemetrycollector_controller.go
@@ -79,13 +79,16 @@ type Params struct {
 func (r *OpenTelemetryCollectorReconciler) Validate(otelcol v1beta1.OpenTelemetryCollector) admission.Warnings {
 	var warnings admission.Warnings
 
-	params, err := r.getParams(otelcol)
-	if err != nil {
-		warnings = append(warnings, err.Error())
-		return warnings
+	cfg := config.New(
+		config.WithCollectorImage("default-collector"),
+		config.WithTargetAllocatorImage("default-ta-allocator"),
+	)
+	params := manifests.Params{
+		Log:     logr.Discard(),
+		Config:  cfg,
+		OtelCol: otelcol,
 	}
-
-	_, err = collector.Build(params)
+	_, err := collector.Build(params)
 	if err != nil {
 		warnings = append(warnings, err.Error())
 		return warnings