Revert "track_rotated"

[djaglowski]

Reverts #168

See #179

[codecov]

Codecov Report

Merging #180 (daaeb61) into main (c46512e) will decrease coverage by 0.1%.
The diff coverage is 47.6%.

@@           Coverage Diff           @@
##            main    #180     +/-   ##
=======================================
- Coverage   75.8%   75.6%   -0.2%     
=======================================
  Files         95      95             
  Lines       4363    4360      -3     
=======================================
- Hits        3308    3298     -10     
- Misses       733     739      +6     
- Partials     322     323      +1     

Impacted Files	Coverage Δ
operator/builtin/input/file/config.go	73.4% <0.0%> (ø)
operator/builtin/input/file/reader.go	65.1% <25.0%> (-3.2%)	⬇️
operator/builtin/input/file/file.go	71.4% <60.0%> (-4.8%)	⬇️
operator/builtin/input/file/fingerprint.go	88.2% <0.0%> (+11.7%)	⬆️

[tigrannajaryan]

Do we need to go back to the drawing board or we know what the right way to fix this is?

[djaglowski]

Do we need to go back to the drawing board or we know what the right way to fix this is?

We didn't need to go back to the drawing board, but there was some investigation required to understand the failures.

We identified two issues and addressed them on #182.

1. The first PR (track_rotated #168) moved some code that protected against duplicated logs in Copy/Truncate scenarios. It made sense for this code to exist in the place it was moved to, but it was also needed in its original position. Thus, it is now replicated rather than moved. Performance benchmarks show trivial difference.
2. We are clarifying that the Move/Create rotation mechanism is not supported on Windows. In theory, FILE_SHARE_DELETE mode would allow this to work, but golang does not support this. Thus, the correct action is to skip those particular tests on windows. I will document this more clearly in the design doc I am writing up.