Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating out of date nyc packages #917

Merged
merged 1 commit into from
Mar 31, 2020
Merged

Updating out of date nyc packages #917

merged 1 commit into from
Mar 31, 2020

Conversation

shivkanya9146
Copy link
Contributor

Which problem is this PR solving?

Short description of the changes

@mayurkale22 mayurkale22 added the dependencies Pull requests that update a dependency file label Mar 31, 2020
obecny
obecny reviewed Mar 31, 2020
View reviewed changes
Copy link
Member

@obecny obecny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

main package.json is not updated

@mayurkale22
Copy link
Member

main package.json is not updated

We don't have nyc dependency in main package.json.

@obecny
Copy link
Member

obecny commented Mar 31, 2020

main package.json is not updated

We don't have nyc dependency in main package.json.

you right, I checked wrong repo :/

@mayurkale22 mayurkale22 merged commit 0d1c82c into open-telemetry:master Mar 31, 2020
dyladan pushed a commit to dyladan/opentelemetry-js that referenced this pull request Sep 9, 2022
@shivkanya9146 @dyladan
Updating out of date nyc packages (open-telemetry#917)
bdb4125
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
@shivkanya9146
Updating out of date nyc packages (open-telemetry#917)
7a57547
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
@trask @dyladan
fix!(ioredis): net.peer.ip -> db.connection_string (open-telemetry#917)
986c349 
Co-authored-by: Daniel Dyla <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mayurkale22 mayurkale22 mayurkale22 approved these changes

@vmarchaud vmarchaud vmarchaud approved these changes

@obecny obecny obecny approved these changes

@bg451 bg451 Awaiting requested review from bg451

@dyladan dyladan Awaiting requested review from dyladan

@markwolff markwolff Awaiting requested review from markwolff

@OlivierAlbertini OlivierAlbertini Awaiting requested review from OlivierAlbertini

@rochdev rochdev Awaiting requested review from rochdev

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shivkanya9146 @mayurkale22 @obecny @vmarchaud