fix: add type checking in propagators #904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dyladan
requested review from
bg451,
markwolff,
mayurkale22,
obecny,
OlivierAlbertini,
rochdev and
vmarchaud
as code owners
|
@jordanworner would appreciate you taking a look at this. |
dyladan
commented
Mar 26, 2020
| @@ -66,7 +66,6 @@ export class B3Propagator implements HttpTextPropagator { | |||
| const traceIdHeader = getter(carrier, X_B3_TRACE_ID); | |||
| const spanIdHeader = getter(carrier, X_B3_SPAN_ID); | |||
| const sampledHeader = getter(carrier, X_B3_SAMPLED); | |||
| if (!traceIdHeader || !spanIdHeader) return context; | |||
| const traceId = Array.isArray(traceIdHeader) | |||
There was a problem hiding this comment.
The root of this issue was that Array.isArray turns our unknown into an any which made the type system not complain like we would have expected.
Codecov Report
@@ Coverage Diff @@
## master #904 +/- ##
==========================================
- Coverage 92.85% 92.60% -0.25%
==========================================
Files 244 243 -1
Lines 10982 10954 -28
Branches 1067 1084 +17
==========================================
- Hits 10197 10144 -53
- Misses 785 810 +25
|
|
@dyladan I applied your fix and retested my gRPC server using both the b3 and trace context propagators and that seems to have fixed it. Requests now work with or without the parent metadata. |
mayurkale22
reviewed
Mar 26, 2020
|
Trying to figure out a good way to test |
|
@mayurkale22 added tests |
mayurkale22
approved these changes
Mar 26, 2020
markwolff
approved these changes
Mar 26, 2020
vmarchaud
approved these changes
Mar 27, 2020
pichlermarc
pushed a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this pull request
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #903