Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove Gauge instrument #791

Merged
merged 3 commits into from
Feb 19, 2020
Merged

Conversation

mayurkale22
Copy link
Member

@mayurkale22 mayurkale22 commented Feb 18, 2020

Which problem is this PR solving?

Updates #739

@mayurkale22 mayurkale22 marked this pull request as ready for review February 18, 2020 19:57
Copy link
Member

@dyladan dyladan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems pretty straightforward, gauge is supposed to be replaced by observer. Is that going to be a separate PR?

@mayurkale22
Copy link
Member Author

This seems pretty straightforward, gauge is supposed to be replaced by observer. Is that going to be a separate PR?

Yes. To keep PR short and simple, I thought to split things into multiple PRs.

Copy link
Member

@dyladan dyladan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case this seems very straightforward to me

@dyladan dyladan merged commit 6616bb1 into open-telemetry:master Feb 19, 2020
dyladan pushed a commit to dyladan/opentelemetry-js that referenced this pull request Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants