-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: minor fixes to API docs #779
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, just a few minor wording suggestions
ae6467b
to
3b4693d
Compare
Codecov Report
@@ Coverage Diff @@
## master #779 +/- ##
==========================================
+ Coverage 92.4% 95.37% +2.96%
==========================================
Files 237 137 -100
Lines 10790 5019 -5771
Branches 997 436 -561
==========================================
- Hits 9971 4787 -5184
+ Misses 819 232 -587
|
@mayurkale22 this is so simple that I'm ok with this just merging if you're ok with it. gave my ✅ and added merge:lgtm label. Feel free to merge when you're ready. |
+1 feel free to merge 👍 |
* chore: fix API docs * update WEB Readme: WebTracer => WebTracerProvider
Co-authored-by: Valentin Marchaud <[email protected]> Co-authored-by: Daniel Dyla <[email protected]>
Short description of the changes
Fix API docs
Rename
NodeTracer
toNodeTracerProvider
.Add missing
@param
Indent continuation lines