-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: port mongodb-core plugin to mongodb #622 #652
feat: port mongodb-core plugin to mongodb #622 #652
Conversation
Codecov Report
@@ Coverage Diff @@
## master #652 +/- ##
===========================================
+ Coverage 56.2% 91.55% +35.35%
===========================================
Files 69 215 +146
Lines 1943 10192 +8249
Branches 236 912 +676
===========================================
+ Hits 1092 9331 +8239
- Misses 851 861 +10
|
8facb6e
to
692ffc6
Compare
@vmarchaud please try not to force push on open PRs if possible. It makes it hard to track requested changes because the github UI doesn't associate the conversations with the correct line numbers anymore. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should put the deprecated message on existing mongodb-core npm module. WDYT? |
ab33373
to
bd908c2
Compare
Tests are failling because |
Actually most of the code was working with the higher level mongodb driver so i didn't change much code.
I've tested on
mongodb
version 2, 3.3 and 3.4 and it's working well.