Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: lint examples #649

Merged
merged 46 commits into from
Jan 24, 2020
Merged
Changes from 1 commit
Commits
Show all changes
46 commits
Select commit Hold shift + click to select a range
26a4036
refactor: use a single eslintrc for all examples folders
naseemkullah Dec 26, 2019
88c8052
fix: turn off no-use-before-define
naseemkullah Dec 26, 2019
1acfa78
fix: install eslint in ci container
naseemkullah Dec 26, 2019
b0fdb87
fix: install eslint modules in ci container
naseemkullah Dec 26, 2019
ece1703
Update examples/.eslintrc
naseemkullah Dec 26, 2019
5414e68
Merge branch 'master' into lint-examples
naseemkullah Dec 26, 2019
b1be28e
feat: add lint:examples script, use airbnb-base rather than airbnb es…
naseemkullah Dec 26, 2019
3530b7d
feat: add lint:examples script
naseemkullah Dec 26, 2019
16cbc99
feat: use lint:examples script
naseemkullah Dec 26, 2019
f347be5
fix: install dev dependencies before running lint examples
naseemkullah Dec 26, 2019
e221f60
fix: do not install dev dependencies
naseemkullah Dec 26, 2019
fbbe37c
fix: typo in module name
naseemkullah Dec 26, 2019
273b1da
fix: run lint-examples script in ci
naseemkullah Dec 26, 2019
0db8d1f
fix: use globally installed eslint in ci
naseemkullah Dec 26, 2019
1884b9f
ci: rerun build
naseemkullah Dec 26, 2019
82a3f4a
ci: rerun build
naseemkullah Dec 26, 2019
218ca03
ci: adjust lint examples step
naseemkullah Dec 27, 2019
0c2ef1a
Merge branch 'master' into lint-examples
dyladan Dec 27, 2019
bf5535b
ci: separate modules installation and linting examples into two steps
naseemkullah Dec 27, 2019
51234dc
feat: add fix-examples script
naseemkullah Dec 27, 2019
9a32d7e
refactor: lint
naseemkullah Dec 27, 2019
d0bf080
Merge branch 'lint-examples' of github.com:naseemkullah/opentelemetry…
naseemkullah Dec 27, 2019
d889c96
refactor: initialize and export tracer in tracer module
naseemkullah Dec 27, 2019
e85268a
style: lint
naseemkullah Dec 31, 2019
63bb20a
style: allow console logs
naseemkullah Dec 31, 2019
115c1ab
style: lint
naseemkullah Dec 31, 2019
79ec75a
fix: tracer module
naseemkullah Dec 31, 2019
970ddb5
style: lint
naseemkullah Dec 31, 2019
715664c
style: lint
naseemkullah Dec 31, 2019
ef6ef07
fix: ignore uninstalled packages lint errors
naseemkullah Dec 31, 2019
d67ef3e
style: prefix unused vars with _ and no error on them
naseemkullah Dec 31, 2019
47e4ebe
fix: require tracer before any other modules
naseemkullah Jan 1, 2020
2914c55
refactor: change var name to match key and use short hand
naseemkullah Jan 2, 2020
8fe34c9
Merge branch 'master' into lint-examples
naseemkullah Jan 3, 2020
7f4e211
Merge branch 'master' into lint-examples
naseemkullah Jan 5, 2020
0e4a3de
fix: add back required package
naseemkullah Jan 5, 2020
c6d1083
Merge branch 'master' into lint-examples
naseemkullah Jan 7, 2020
1c85aa0
fix: conflicts
Jan 14, 2020
7b44d9e
Merge branch 'lint-examples' of github.com:naseemkullah/opentelemetry…
Jan 14, 2020
a88c683
fix: lint
Jan 14, 2020
64b1b9f
Merge branch 'master' into lint-examples
Jan 18, 2020
c255d53
Merge branch 'master' into lint-examples
Jan 20, 2020
d56057c
fix: lint
Jan 20, 2020
2a79dcd
fix: lint scripts
Jan 20, 2020
01bd85c
Merge remote-tracking branch 'upstream/master' into lint-examples
Jan 23, 2020
facb224
Merge branch 'master' into lint-examples
mayurkale22 Jan 23, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: install eslint modules in ci container
  • Loading branch information
naseemkullah committed Dec 26, 2019
commit b0fdb87970ae0591ef061e1ddb1656ec2644f23c
2 changes: 1 addition & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ jobs:
- checkout
- run:
name: Install minimal doc and lint modules globally
command: yarn global add lerna typedoc linkinator typescript gts tslint-consistent-codestyle tslint-microsoft-contrib eslint
command: yarn global add lerna typedoc linkinator typescript gts tslint-consistent-codestyle tslint-microsoft-contrib eslint eslint-plugin-import eslint-config-airbnb
- run:
name: Symlink global modules into all lerna packages
command: lerna exec 'ln -s $(yarn global dir)/node_modules node_modules'
Expand Down