-
Notifications
You must be signed in to change notification settings - Fork 836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(plugin-dns): remove from default plugin list #613
Merged
mayurkale22
merged 2 commits into
open-telemetry:master
from
VilledeMontreal:feature/remove-dns-in-default
Dec 12, 2019
Merged
fix(plugin-dns): remove from default plugin list #613
mayurkale22
merged 2 commits into
open-telemetry:master
from
VilledeMontreal:feature/remove-dns-in-default
Dec 12, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes open-telemetry#612 Signed-off-by: Olivier Albertini <[email protected]>
OlivierAlbertini
requested review from
bg451,
danielkhan,
markwolff,
mayurkale22,
obecny,
rochdev and
vmarchaud
as code owners
December 11, 2019 17:02
Codecov Report
@@ Coverage Diff @@
## master #613 +/- ##
==========================================
- Coverage 90.44% 90.39% -0.05%
==========================================
Files 181 176 -5
Lines 9164 9062 -102
Branches 814 792 -22
==========================================
- Hits 8288 8192 -96
+ Misses 876 870 -6
|
mayurkale22
approved these changes
Dec 11, 2019
dyladan
approved these changes
Dec 11, 2019
mayurkale22
added
Agreed
bug
Something isn't working
Merge:LGTM
This PR is ready to be merged by a Maintainer (has enough valid approvals, successful build, etc.)
labels
Dec 11, 2019
vmarchaud
approved these changes
Dec 12, 2019
pichlermarc
pushed a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this pull request
Dec 15, 2023
open-telemetry#613) Co-authored-by: Valentin Marchaud <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
Merge:LGTM
This PR is ready to be merged by a Maintainer (has enough valid approvals, successful build, etc.)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes