-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(docs:postgres): add usage instructions #539
chore(docs:postgres): add usage instructions #539
Conversation
Codecov Report
@@ Coverage Diff @@
## master #539 +/- ##
==========================================
- Coverage 91.91% 89.74% -2.17%
==========================================
Files 169 192 +23
Lines 8249 10095 +1846
Branches 726 911 +185
==========================================
+ Hits 7582 9060 +1478
- Misses 667 1035 +368
|
packages/opentelemetry-plugin-postgres/opentelemetry-plugin-pg/README.md
Show resolved
Hide resolved
``` | ||
|
||
See [examples/postgres](https://github.com/open-telemetry/opentelemetry-js/tree/master/examples/postgres) for a short example. | ||
|
||
## Supported Versions | ||
|
||
- [pg](https://npmjs.com/package/pg): `7.x` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it necessary to add supported version of pg-pool here?
- pg-pool:
2.x
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call. Added in 0af2c10
Which problem is this PR solving?
Short description of the changes
pg
plugin. Since thepg
module has a dependency on thepg-pool
package, these instructions also includepg-pool
references/links. These links are broken untilpg-pool
stuff gets merged in.