Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: migrate away from defunct addMetricReader in examples #5349

Merged
merged 4 commits into from
Jan 24, 2025

Conversation

chancancode
Copy link
Contributor

@chancancode chancancode commented Jan 17, 2025

Which problem is this PR solving?

Update READMEs and examples to migrate away from addMetricReader, which was removed in #4419.

Don't think it needs a CHANGELOG entry, since there is already one for #4419 (but it was duplicated for some reason so I fixed it).

Related: open-telemetry/opentelemetry-js-contrib#2646 (comment) (cc @pichlermarc @trentm)

Short description of the changes

Updated to use the constructor option.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Eyeballed it 👁️👄👁️ 🤷🏼‍♂️

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

The code has been removed in open-telemetry#4419, but some examples hasn't been
updated.
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.54%. Comparing base (0ae25f1) to head (76453b7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5349   +/-   ##
=======================================
  Coverage   94.54%   94.54%           
=======================================
  Files         318      318           
  Lines        8052     8052           
  Branches     1694     1694           
=======================================
  Hits         7613     7613           
  Misses        439      439           
Files with missing lines Coverage Δ
...es/shim-opencensus/src/OpenCensusMetricProducer.ts 100.00% <ø> (ø)

doc/metrics.md Outdated Show resolved Hide resolved
@pichlermarc pichlermarc added this pull request to the merge queue Jan 24, 2025
Merged via the queue into open-telemetry:main with commit f927e82 Jan 24, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants