Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update README with plugins work and add DNS plugin in default … #529

Merged
merged 2 commits into from
Nov 15, 2019

Conversation

mayurkale22
Copy link
Member

…supported plugins list

Which problem is this PR solving?

  • Add a line about @opentelemetry/base package.

  • Remove WIP from opentelemetry-exporter-prometheus package.

  • Add WIP plugins (redis and mysql)

  • Add DNS plugin in default supported plugins list

@codecov-io
Copy link

codecov-io commented Nov 13, 2019

Codecov Report

Merging #529 into master will decrease coverage by 3.93%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #529      +/-   ##
==========================================
- Coverage   96.46%   92.53%   -3.94%     
==========================================
  Files         128      146      +18     
  Lines        6455     7168     +713     
  Branches      556      621      +65     
==========================================
+ Hits         6227     6633     +406     
- Misses        228      535     +307
Impacted Files Coverage Δ
...telemetry-plugin-grpc/test/utils/assertionUtils.ts 100% <0%> (ø) ⬆️
.../opentelemetry-plugin-dns/test/utils/assertSpan.ts 100% <0%> (ø) ⬆️
...try-node/test/instrumentation/PluginLoader.test.ts 100% <0%> (ø) ⬆️
...try-plugin-dns/test/functionals/dns-enable.test.ts 100% <0%> (ø) ⬆️
...ckages/opentelemetry-exporter-zipkin/src/zipkin.ts 100% <0%> (ø)
...-document-load/src/enums/PerformanceTimingNames.ts 100% <0%> (ø)
...entelemetry-scope-zone-peer-dep/test/utils.test.ts 0% <0%> (ø)
...ages/opentelemetry-scope-zone-peer-dep/src/util.ts 100% <0%> (ø)
...-scope-zone-peer-dep/test/ZoneScopeManager.test.ts 0% <0%> (ø)
...ges/opentelemetry-exporter-zipkin/test/e2e.test.ts 100% <0%> (ø)
... and 20 more

Copy link
Member

@obecny obecny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mayurkale22 mayurkale22 merged commit 0c1ff8d into open-telemetry:master Nov 15, 2019
@mayurkale22 mayurkale22 deleted the update_readme branch November 15, 2019 15:37
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
martinkuba pushed a commit to martinkuba/opentelemetry-js that referenced this pull request Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants