Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(resources)!: unify resource interfaces #5205

Draft
wants to merge 1 commit into
base: next
Choose a base branch
from

Conversation

david-luna
Copy link
Contributor

Which problem is this PR solving?

This PR removes the deprecated DetectorAsync interface and also simplifies the IResource interfaces and Resource class implementation.

Fixes #3582

Short description of the changes

  • IResource refactored to have an async property (attributes).
  • refactored Resource class to comply with the new interface
  • adapted test for the new interface and implementation
  • remove test about sync attributes

Type of change

Please delete options that are not relevant.

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

TODO:

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been adapted
  • Documentation has been updated

@david-luna david-luna changed the title chore(resources): unify resource interfaces refactor(resources)!: unify resource interfaces Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant