Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use yarn workspaces #509

Closed

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Nov 8, 2019

Which problem is this PR solving?

Short description of the changes

Install dependencies using shared locations as much as possible using yarn workspaces. This should drastically speed up installation times. See #504 for details.

@codecov-io
Copy link

codecov-io commented Nov 8, 2019

Codecov Report

Merging #509 into master will decrease coverage by 34.11%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master     #509       +/-   ##
===========================================
- Coverage   88.54%   54.43%   -34.12%     
===========================================
  Files         116       43       -73     
  Lines        5561     1106     -4455     
  Branches      502      119      -383     
===========================================
- Hits         4924      602     -4322     
+ Misses        637      504      -133
Impacted Files Coverage Δ
...telemetry-plugin-document-load/src/documentLoad.ts 98.03% <0%> (-0.06%) ⬇️
...y-core/src/context/propagation/HttpTraceContext.ts 100% <0%> (ø) ⬆️
packages/opentelemetry-tracing/src/Span.ts
...pe-async-hooks/test/AsyncHooksScopeManager.test.ts
...ntelemetry-node/test/instrumentation/utils.test.ts
...postgres/opentelemetry-plugin-pg/test/testUtils.ts
...ges/opentelemetry-exporter-jaeger/src/transform.ts
...ges/opentelemetry-exporter-zipkin/test/e2e.test.ts
packages/opentelemetry-metrics/src/Utils.ts
...telemetry-tracing/src/export/BatchSpanProcessor.ts
... and 65 more

@dyladan
Copy link
Member Author

dyladan commented Nov 8, 2019

This actually might make #508 unnecessary. The install step is so much faster that the lint and docs step is now under a minute even without the optimization https://circleci.com/gh/open-telemetry/opentelemetry-js/7773

@dyladan
Copy link
Member Author

dyladan commented Nov 8, 2019

Closing because it seems fundamentally incompatible with the require-in-the middle and monkey patching we're doing.

@dyladan dyladan closed this Nov 8, 2019
@Flarna Flarna deleted the workspaces branch December 13, 2019 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants