test(otlp-grpc-exporter-base): do not use hard-coded version in tests, touch up changelog entries #5069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pichlermarc
force-pushed
the
test/no-hardcoded-versions
branch
from
3a8e67c to
eb4f970
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5069 +/- ##
==========================================
+ Coverage 93.26% 93.27% +0.01%
==========================================
Files 317 317
Lines 8195 8195
Branches 1641 1641
==========================================
+ Hits 7643 7644 +1
+ Misses 552 551 -1 |
david-luna
approved these changes
Oct 15, 2024
Annosha
pushed a commit
to Annosha/opentelemetry-js
that referenced
this pull request
Oct 19, 2024
…, touch up changelog entries (open-telemetry#5069)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
See test failure in #5068, after we updated the versions, the tests failed because they were hardcoded. This PR fixes this, and also moves some changelog entries to the correct spot (I had put them in bugfix but they belong in the breaking changes section).
Type of change
How Has This Been Tested?