-
Notifications
You must be signed in to change notification settings - Fork 838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(exporter-metrics-otlp-*): configure histogram aggregation #5061
feat(exporter-metrics-otlp-*): configure histogram aggregation #5061
Conversation
Signed-off-by: APPLE <[email protected]>
|
@@ -71,6 +71,7 @@ | |||
}, | |||
"dependencies": { | |||
"@opentelemetry/api-logs": "0.53.0", | |||
"@opentelemetry/sdk-logs": "^0.53.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this change intentional? I don't see any usage of the sdk-logs
package in the example above.
@olabodeIdowu thanks for taking the time to work on this, but I think like this PR missed the original intent of what the author of #3920 wanted to be implemented (see the linked specification on #3920). This is adding an example not the actual feature. Many of our issues are not yet well defined, so if anything is unclear, please ask questions on the issues first, and then ask to be assigned to issues once you're ready to start working on it. While this is not exciting work that involves coding, asking well thought out questions is still very important as this will save everyone a lot of time in the long run:
Please also note that all issues labelled |
alright. thank you @pichlermarc |
Which problem is this PR solving?
Fixes 3920
Short description of the changes
To implement default histogram aggregation for OTLP Metrics exporters, you can use the OpenTelemetry library. The sample code snippet demonstrates how to allow for either Explicit Bucket histogram aggregation or Exponential histogram aggregation based on an environment variable.
Explanation:
Usage:
Type of change
New feature (non-breaking change which adds functionality)
How Has This Been Tested?
Recorded some values in the histogram
Checklist: