Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: use npm ci in CONTRIBUTING.md #5040

Conversation

pichlermarc
Copy link
Member

Which problem is this PR solving?

we still recommend using npm install in the docs, but we now include a package-lock.json so npm ci provides a better development experience.

@pichlermarc pichlermarc added document Documentation-related Skip Changelog labels Oct 4, 2024
@pichlermarc pichlermarc requested a review from a team as a code owner October 4, 2024 12:41
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.27%. Comparing base (f8ab559) to head (f22a3f0).
Report is 29 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5040      +/-   ##
==========================================
- Coverage   93.39%   93.27%   -0.13%     
==========================================
  Files          46      317     +271     
  Lines         712     8194    +7482     
  Branches      120     1640    +1520     
==========================================
+ Hits          665     7643    +6978     
- Misses         47      551     +504     

see 266 files with indirect coverage changes

@JamieDanielson JamieDanielson added this pull request to the merge queue Oct 7, 2024
Merged via the queue into open-telemetry:main with commit 6ccd4df Oct 7, 2024
21 checks passed
@pichlermarc pichlermarc deleted the chore/fix-contributing-md branch October 8, 2024 12:58
Annosha pushed a commit to Annosha/opentelemetry-js that referenced this pull request Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
document Documentation-related Skip Changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants