Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ConsoleMetricExporter #500

Merged

Conversation

mayurkale22
Copy link
Member

Which problem is this PR solving?

@codecov-io
Copy link

codecov-io commented Nov 6, 2019

Codecov Report

Merging #500 into master will increase coverage by 0.18%.
The diff coverage is 97.29%.

@@            Coverage Diff             @@
##           master     #500      +/-   ##
==========================================
+ Coverage   90.03%   90.22%   +0.18%     
==========================================
  Files         140      142       +2     
  Lines        6823     6975     +152     
  Branches      609      619      +10     
==========================================
+ Hits         6143     6293     +150     
- Misses        680      682       +2
Impacted Files Coverage Δ
...-metrics/test/export/ConsoleMetricExporter.test.ts 100% <100%> (ø)
...emetry-metrics/src/export/ConsoleMetricExporter.ts 93.75% <93.75%> (ø)
...ages/opentelemetry-plugin-http/test/utils/utils.ts 33.33% <0%> (-26.67%) ⬇️
packages/opentelemetry-tracing/src/config.ts 100% <0%> (ø) ⬆️
packages/opentelemetry-tracing/src/utility.ts 100% <0%> (ø) ⬆️
...telemetry-plugin-grpc/test/utils/assertionUtils.ts 100% <0%> (ø) ⬆️
...entelemetry-exporter-jaeger/test/transform.test.ts 100% <0%> (ø) ⬆️
packages/opentelemetry-tracing/test/Span.test.ts 100% <0%> (ø) ⬆️
...ry-tracing/test/export/SimpleSpanProcessor.test.ts 100% <0%> (ø) ⬆️
.../opentelemetry-exporter-jaeger/test/jaeger.test.ts 100% <0%> (ø) ⬆️
... and 10 more

@mayurkale22 mayurkale22 force-pushed the console_metric_exporter branch 2 times, most recently from 88ed05d to 9b5c326 Compare November 8, 2019 22:38
@dyladan
Copy link
Member

dyladan commented Nov 8, 2019

This LGTM. Looks like you have a lint failure but once that's green I think this is good to go.

@mayurkale22 mayurkale22 force-pushed the console_metric_exporter branch from e722f7d to 63f7900 Compare November 11, 2019 17:49
@mayurkale22 mayurkale22 merged commit 39732fa into open-telemetry:master Nov 11, 2019
@mayurkale22 mayurkale22 deleted the console_metric_exporter branch November 11, 2019 18:06
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add/Implement ConsoleMetricsExporter
5 participants