fix(instrumentation): Fix optional property types #4833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pichlermarc @dyladan Friendly ping 😉 |
|
@pichlermarc @dyladan @legendecas @blumamir Friendly ping! |
legendecas
approved these changes
Aug 13, 2024
|
Would you mind updating the PR title and commit message according to the guide https://github.com/open-telemetry/opentelemetry-js/blob/main/CONTRIBUTING.md#conventional-commit ? thank you! |
TypeScript emits InstrumentationNodeModuleDefinition with " | undefined" for some reason, making it incompatible with InstrumentationModuleDefinition under exactOptionalPropertyTypes.
|
@legendecas Sure thing, done 😉 |
|
Thanks! 👍 |
Zirak
pushed a commit
to Zirak/opentelemetry-js
that referenced
this pull request
Sep 14, 2024
This was referenced Sep 19, 2024
This was referenced Oct 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Fix #4712, related to #3713.
TypeScript emits
InstrumentationNodeModuleDefinitionwith| undefinedfor some reason, making it incompatible withInstrumentationModuleDefinitionunderexactOptionalPropertyTypes: true.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
I'm using OpenTelemetry indirectly via Sentry. I applied this patch locally to the latest version of
@opentelemetry/instrumentationand it resolved the issue.Checklist: