-
Notifications
You must be signed in to change notification settings - Fork 810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(otlp-transformer): use explicit exports #4785
Merged
pichlermarc
merged 4 commits into
open-telemetry:main
from
dynatrace-oss-contrib:refactor/otlp-transformer-explicit-exports
Jun 12, 2024
Merged
refactor(otlp-transformer): use explicit exports #4785
pichlermarc
merged 4 commits into
open-telemetry:main
from
dynatrace-oss-contrib:refactor/otlp-transformer-explicit-exports
Jun 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pichlermarc
changed the title
refactor(otlp-transformer): use explicit exports @pichlermarc
refactor(otlp-transformer): use explicit exports
Jun 12, 2024
pichlermarc
commented
Jun 12, 2024
pichlermarc
commented
Jun 12, 2024
trentm
approved these changes
Jun 12, 2024
This was referenced Jul 12, 2024
Closed
Closed
This was referenced Aug 15, 2024
This was referenced Sep 12, 2024
Open
Zirak
pushed a commit
to Zirak/opentelemetry-js
that referenced
this pull request
Sep 14, 2024
* refactor(otlp-transformer): use explicit exports * chore: add changelog entry * Update experimental/CHANGELOG.md * Update experimental/CHANGELOG.md
This was referenced Sep 19, 2024
This was referenced Sep 20, 2024
This was referenced Sep 24, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the exports of the
@opentelemetry/otlp-transformer
package to be explicit overexport * from
. This will help us reduce the API surface of the@opentelemetry/otlp-transformer
package now that #4581 and #4542 is merged in and many of these types are not needed anymore.By first converting to explicit exports, it will be easier to review future PRs that will remove those exports.
Part of #4583