Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(examples/grpc-js): use new exported string constants for semconv #4760

Merged
merged 4 commits into from
Jun 5, 2024
Merged

refactor(examples/grpc-js): use new exported string constants for semconv #4760

merged 4 commits into from
Jun 5, 2024

Conversation

Zen-cronic
Copy link
Contributor

Which problem is this PR solving?

Updates #4567

Short description of the changes

Replaced deprecated import (SemanticResourceAttributes) from @opentelemetry/semantic-conventions with new string constants (SEMRESATTRS_SERVICE_NAME) for the example grpc-js package

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • npm test

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

@Zen-cronic Zen-cronic requested a review from a team June 4, 2024 14:06
JamieDanielson
JamieDanielson reviewed Jun 4, 2024
View reviewed changes
Copy link
Member

@JamieDanielson JamieDanielson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The semantic conventions package should be updated in the package.json as well. And can you also add a changelog entry?

@JamieDanielson JamieDanielson mentioned this pull request Jun 4, 2024
Closed
24 tasks
@pichlermarc pichlermarc added this pull request to the merge queue Jun 5, 2024
Merged via the queue into open-telemetry:main with commit 929e345 Jun 5, 2024
17 of 18 checks passed
@pichlermarc pichlermarc mentioned this pull request Jun 5, 2024
Merged
This was referenced Jun 27, 2024
Merged
Merged
Merged
@AlexOnyi AlexOnyi mentioned this pull request Jun 30, 2024
Open
@moishimwe moishimwe mentioned this pull request Jun 30, 2024
Open
@marcelineepi marcelineepi mentioned this pull request Jun 30, 2024
Open
@keemraheem keemraheem mentioned this pull request Jun 30, 2024
Open
This was referenced Jul 3, 2024
Closed
Closed
Closed
Closed
Closed
@fakure2020 fakure2020 mentioned this pull request Jul 3, 2024
Open
This was referenced Jul 4, 2024
Closed
Closed
Closed
Closed
Closed
This was referenced Jul 5, 2024
Open
Open
Open
Open
Open
This was referenced Jul 17, 2024
Open
Open
This was referenced Jul 17, 2024
Open
Open
Open
@rathorevs rathorevs mentioned this pull request Jul 18, 2024
Open
@harshakrithvikk harshakrithvikk mentioned this pull request Jul 24, 2024
Open
@krischarbonneau krischarbonneau mentioned this pull request Jul 30, 2024
Closed
@SoniaBoussabeh SoniaBoussabeh mentioned this pull request Sep 11, 2024
Open
This was referenced Sep 12, 2024
Open
Open
Open
Open
Open
Open
Zirak pushed a commit to Zirak/opentelemetry-js that referenced this pull request Sep 14, 2024
@Zen-cronic @pichlermarc @Zirak
refactor(examples/grpc-js): use new exported string constants for sem…
bcc02a7 
…conv (open-telemetry#4760)

* refactor(examples/grpc-js): use new exported string constants for semconv

* updated semconv package ^1.22.0

* added changelog entry

---------

Co-authored-by: Marc Pichler <[email protected]>
This was referenced Sep 16, 2024
Open
Open
@gyenoch gyenoch mentioned this pull request Oct 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamieDanielson JamieDanielson JamieDanielson left review comments

@pichlermarc pichlermarc pichlermarc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Zen-cronic @pichlermarc @JamieDanielson