-
Notifications
You must be signed in to change notification settings - Fork 810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(instr-http): use exported strings for semconv #4573
Merged
pichlermarc
merged 2 commits into
open-telemetry:main
from
JamieDanielson:jamie.http-semconv
Mar 22, 2024
Merged
refactor(instr-http): use exported strings for semconv #4573
pichlermarc
merged 2 commits into
open-telemetry:main
from
JamieDanielson:jamie.http-semconv
Mar 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4573 +/- ##
==========================================
+ Coverage 92.83% 92.84% +0.01%
==========================================
Files 328 328
Lines 9487 9487
Branches 2035 2035
==========================================
+ Hits 8807 8808 +1
+ Misses 680 679 -1
|
pichlermarc
approved these changes
Mar 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just missing a changelog entry (conventional commit type might be refactor as opposed to chore) 🙂
Thanks for taking care of this 👍
JamieDanielson
changed the title
chore(instr-http): use exported strings for semconv
refactor(instr-http): use exported strings for semconv
Mar 22, 2024
MSNev
approved these changes
Mar 22, 2024
24 tasks
This was referenced May 28, 2024
Open
Zirak
pushed a commit
to Zirak/opentelemetry-js
that referenced
this pull request
Sep 14, 2024
…y#4573) * chore(instr-http): use exported strings for semconv * add changelog entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Updates #4567
Short description of the changes
SemanticAttributes.*
,NetTransportValues.*
, andHttpFlavorValues.*
with specific exported strings for http instrumentation package.Type of change
Not quite sure; chore to replace deprecated fields but feature to improve minification?
How Has This Been Tested?
Checklist: