-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(span): rename span recording flag #454
Conversation
Codecov Report
@@ Coverage Diff @@
## master #454 +/- ##
=======================================
Coverage 95.38% 95.38%
=======================================
Files 123 123
Lines 6104 6104
Branches 507 506 -1
=======================================
Hits 5822 5822
Misses 282 282
|
CLA signed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, added one minor comment.
Co-Authored-By: Mayur Kale <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
run gts fix to pass the build. LGTM
Which problem is this PR solving?
Short description of the changes