feat(instrumentation): add getModuleDefinitions() instead of making init() public
#4475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4475 +/- ##
==========================================
- Coverage 92.55% 92.43% -0.13%
==========================================
Files 315 330 +15
Lines 9375 9525 +150
Branches 2013 2033 +20
==========================================
+ Hits 8677 8804 +127
- Misses 698 721 +23
|
|
@pichlermarc yes this should also work! thank you! |
drewcorlin1
approved these changes
Feb 12, 2024
I'll also get back to the esbuild MR once this has been merged, just been waiting to use this without all the |
dyladan
approved these changes
Feb 14, 2024
This was referenced May 28, 2024
Open
Zirak
pushed a commit
to Zirak/opentelemetry-js
that referenced
this pull request
Sep 14, 2024
… `init()` public (open-telemetry#4475) * feat(instrumentation): add getModuleDefinitions() instead of making init() public * test(instrumetation): add tests for getModuleDefinitions() * chore: changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Reviewing all changes for the next release, I've just realized that the changes from #4418 would be breaking for implementations that add the
protectedkeyword toinit(), which turns out to be a lot of them in contrib. This is my proposal, adding a new method that should have the same effect, but won't require changes to instrumentations.cc @drewcorlin1, I think this would also work, right?
cc @dyladan since you also reviewed #4418
Relates to #4418
Short description of the changes
Type of change
Please delete options that are not relevant.
How Has This Been Tested?