Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: batchSpanProcessor test failing intermittently #444

Merged
merged 2 commits into from
Oct 21, 2019
Merged

fix: batchSpanProcessor test failing intermittently #444

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
83a1462
fix: batchSpanProcessor test failing intermittently
mayurkale22 Oct 21, 2019
5ae722b
Merge branch 'master' into fix_test
mayurkale22 Oct 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/opentelemetry-tracing/test/export/BatchSpanProcessor.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,16 +60,19 @@ describe('BatchSpanProcessor', () => {
it('should create a BatchSpanProcessor instance', () => {
const processor = new BatchSpanProcessor(exporter);
assert.ok(processor instanceof BatchSpanProcessor);
processor.shutdown();
});

it('should create a BatchSpanProcessor instance with config', () => {
const processor = new BatchSpanProcessor(exporter, defaultBufferConfig);
assert.ok(processor instanceof BatchSpanProcessor);
processor.shutdown();
mayurkale22 marked this conversation as resolved.
Show resolved Hide resolved
});

it('should create a BatchSpanProcessor instance with empty config', () => {
const processor = new BatchSpanProcessor(exporter, {});
assert.ok(processor instanceof BatchSpanProcessor);
processor.shutdown();
});
});

Expand Down Expand Up @@ -100,6 +103,7 @@ describe('BatchSpanProcessor', () => {
processor.onEnd(span);
assert.strictEqual(exporter.getFinishedSpans().length, 0);
}
processor.shutdown();
});

it('should force flush when timeout exceeded', done => {
Expand Down