-
Notifications
You must be signed in to change notification settings - Fork 812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(core): drop unnecessary assignment of HOSTNAME #4421
Merged
legendecas
merged 5 commits into
open-telemetry:main
from
dynatrace-oss-contrib:fix/4405
Jan 18, 2024
Merged
refactor(core): drop unnecessary assignment of HOSTNAME #4421
legendecas
merged 5 commits into
open-telemetry:main
from
dynatrace-oss-contrib:fix/4405
Jan 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pichlermarc
changed the title
fix(core): drop unnecessary assignemnt of HOSTNAME
fix(core): drop unnecessary assignment of HOSTNAME
Jan 16, 2024
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4421 +/- ##
==========================================
+ Coverage 92.19% 92.21% +0.02%
==========================================
Files 336 336
Lines 9512 9511 -1
Branches 2016 2016
==========================================
+ Hits 8770 8771 +1
+ Misses 742 740 -2
|
pichlermarc
added
bug
Something isn't working
pkg:core
priority:p4
Bugs and spec inconsistencies which do not fall into a higher prioritization
labels
Jan 16, 2024
legendecas
reviewed
Jan 17, 2024
pichlermarc
changed the title
fix(core): drop unnecessary assignment of HOSTNAME
refactor(core): drop unnecessary assignment of HOSTNAME
Jan 17, 2024
pichlermarc
commented
Jan 17, 2024
legendecas
approved these changes
Jan 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM % a nit
Zirak
pushed a commit
to Zirak/opentelemetry-js
that referenced
this pull request
Sep 14, 2024
…ry#4421) * fix(core): drop unnecessary assignemnt of HOSTNAME * fix(changelog): add changelog entry * Update CHANGELOG.md * fix(changelog): move entry to internal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
pkg:core
priority:p4
Bugs and spec inconsistencies which do not fall into a higher prioritization
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
We currently try to assign
os.hostname()
as the default, but we override it with the emtpy string fromDEFAULT_ENVIRONMENT
. This PR removes that assignment ofHOSTNAME
as it's not doing anything.While we don't use
HOSTNAME
anywhere other than in tests,getEnv()
may be used by consumers of the@opentelemetry/core
library and they might depend on the default for that value being the empty string. Also sincegetEnv()
indicates us getting environment variables, I think we should not fall back to anything that's not a static default (as is the case for all other variables).Fixes #4405
Type of change
How Has This Been Tested?