Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(pg): add postgres plugin skeleton #411

Merged

Conversation

markwolff
Copy link
Member

Which problem is this PR solving?

Short description of the changes

  • Adds skeleton for postgres plugin

@@ -0,0 +1,61 @@
{
"name": "@opentelemetry/plugin-postgres",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsure if this should be named plugin-postgres or plugin-pg. The actual npm package name is pg and not postgres, so naming it plugin-pg would be less confusing. Naming it plugin-postgres gives better visibility of what the plugin does.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for plugin-postgres.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for plugin-postgres.

@mayurkale22
Copy link
Member

To unblock @markwolff, I'd like to merge this PR. We can rename package later, if required.

@mayurkale22 mayurkale22 merged commit 3b3030c into open-telemetry:master Oct 8, 2019
@markwolff markwolff deleted the markwolff/add-pg-plugin branch October 8, 2019 17:09
lukaswelinder pushed a commit to agile-pm/opentelemetry-js that referenced this pull request Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants