-
Notifications
You must be signed in to change notification settings - Fork 814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(sdk-node): add notice to manually install '@opentelemetry/exporter-jaeger' #4068
Merged
pichlermarc
merged 10 commits into
open-telemetry:main
from
dynatrace-oss-contrib:chore/sdk-node-jaeger-notice
Aug 29, 2023
Merged
chore(sdk-node): add notice to manually install '@opentelemetry/exporter-jaeger' #4068
pichlermarc
merged 10 commits into
open-telemetry:main
from
dynatrace-oss-contrib:chore/sdk-node-jaeger-notice
Aug 29, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4068 +/- ##
==========================================
- Coverage 92.56% 92.38% -0.18%
==========================================
Files 317 321 +4
Lines 9213 9276 +63
Branches 1957 1970 +13
==========================================
+ Hits 8528 8570 +42
- Misses 685 706 +21 |
4 tasks
dyladan
reviewed
Aug 16, 2023
Co-authored-by: Daniel Dyla <[email protected]>
Vadman97
approved these changes
Aug 22, 2023
legendecas
approved these changes
Aug 23, 2023
legendecas
reviewed
Aug 23, 2023
dyladan
approved these changes
Aug 23, 2023
dyladan
added
the
Merge:LGTM
This PR is ready to be merged by a Maintainer (has enough valid approvals, successful build, etc.)
label
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Merge:LGTM
This PR is ready to be merged by a Maintainer (has enough valid approvals, successful build, etc.)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Add a notice that '@opentelemetry/exporter-jaeger' has to be installed manually starting
0.43.0
.Reasoning:
@opentelemetry/exporter-jaeger
is deprecatedThis PR is a prerequisite for #4049
Type of change
How Has This Been Tested?