Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sdk-node): add notice to manually install '@opentelemetry/exporter-jaeger' #4068

Conversation

pichlermarc
Copy link
Member

Which problem is this PR solving?

Add a notice that '@opentelemetry/exporter-jaeger' has to be installed manually starting 0.43.0.

Reasoning:

This PR is a prerequisite for #4049

Type of change

  • (preparing for) breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

  • Run postinstall locally

@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #4068 (b9301b8) into main (dfe9bdd) will decrease coverage by 0.18%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

❗ Current head b9301b8 differs from pull request most recent head 9f92395. Consider uploading reports for the commit 9f92395 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4068      +/-   ##
==========================================
- Coverage   92.56%   92.38%   -0.18%     
==========================================
  Files         317      321       +4     
  Lines        9213     9276      +63     
  Branches     1957     1970      +13     
==========================================
+ Hits         8528     8570      +42     
- Misses        685      706      +21     

see 5 files with indirect coverage changes

@pichlermarc pichlermarc marked this pull request as ready for review August 16, 2023 12:29
@pichlermarc pichlermarc requested a review from a team August 16, 2023 12:29
@dyladan dyladan added the Merge:LGTM This PR is ready to be merged by a Maintainer (has enough valid approvals, successful build, etc.) label Aug 23, 2023
@pichlermarc pichlermarc merged commit 432d439 into open-telemetry:main Aug 29, 2023
14 checks passed
@pichlermarc pichlermarc deleted the chore/sdk-node-jaeger-notice branch August 29, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Merge:LGTM This PR is ready to be merged by a Maintainer (has enough valid approvals, successful build, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants