-
Notifications
You must be signed in to change notification settings - Fork 813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(zipkin-exporter): round duration for zipkin #4064
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4064 +/- ##
=======================================
Coverage 92.37% 92.37%
=======================================
Files 321 321
Lines 9273 9273
Branches 1970 1970
=======================================
Hits 8566 8566
Misses 707 707
|
Please update the changelog. I suggest something like |
@dyladan thank you for the suggestion. I've updated the changelog |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! 🙂
Any expected release date for this fix ? |
Which problem is this PR solving?
exporter-zipkin export traces correctly to zipkin.
Fixes #4056
Short description of the changes
Round the duration for zipkin.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: