Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(zipkin-exporter): round duration for zipkin #4064

Merged
merged 4 commits into from
Aug 17, 2023
Merged

fix(zipkin-exporter): round duration for zipkin #4064

merged 4 commits into from
Aug 17, 2023

Conversation

n0cloud
Copy link
Contributor

@n0cloud n0cloud commented Aug 15, 2023

Which problem is this PR solving?

exporter-zipkin export traces correctly to zipkin.

Fixes #4056

Short description of the changes

Round the duration for zipkin.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Unit tests for zipkin-exporter
  • Tested in a project by using a patch

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

@n0cloud n0cloud requested a review from a team August 15, 2023 17:48
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 15, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #4064 (8f4b733) into main (5259a0b) will not change coverage.
The diff coverage is n/a.

❗ Current head 8f4b733 differs from pull request most recent head cf7a365. Consider uploading reports for the commit cf7a365 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4064   +/-   ##
=======================================
  Coverage   92.37%   92.37%           
=======================================
  Files         321      321           
  Lines        9273     9273           
  Branches     1970     1970           
=======================================
  Hits         8566     8566           
  Misses        707      707           
Files Changed Coverage Δ
...ges/opentelemetry-exporter-zipkin/src/transform.ts 90.90% <ø> (ø)

@dyladan
Copy link
Member

dyladan commented Aug 16, 2023

Please update the changelog. I suggest something like fix(exporter-zipkin): round span durations to the nearest millisecond to be compliant with zipkin protocol

@n0cloud
Copy link
Contributor Author

n0cloud commented Aug 16, 2023

@dyladan thank you for the suggestion. I've updated the changelog

Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! 🙂

@pichlermarc pichlermarc merged commit b400c2e into open-telemetry:main Aug 17, 2023
10 checks passed
@n0cloud n0cloud deleted the fix-zipkin-exporter branch August 17, 2023 15:18
@rakeshlanjewar
Copy link

Any expected release date for this fix ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zipkin expected a long
5 participants