-
Notifications
You must be signed in to change notification settings - Fork 814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(guidelines): add dependencies guidelines #4040
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4040 +/- ##
==========================================
- Coverage 92.37% 90.52% -1.86%
==========================================
Files 321 159 -162
Lines 9273 3756 -5517
Branches 1970 835 -1135
==========================================
- Hits 8566 3400 -5166
+ Misses 707 356 -351 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this 🙂
I've made some suggestions, no need to apply them all, feel free to change and adapt what fits 🙂
Co-authored-by: Marc Pichler <[email protected]>
Co-authored-by: Marc Pichler <[email protected]>
Co-authored-by: Marc Pichler <[email protected]>
Co-authored-by: Marc Pichler <[email protected]>
Co-authored-by: Marc Pichler <[email protected]>
Co-authored-by: Marc Pichler <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of this 🙂
Co-authored-by: Marc Pichler <[email protected]>
Co-authored-by: Marc Pichler <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The guidelines look good to me!
However, we have lots of files in the root directory already. It might be a good alternative to put the guideline in https://github.com/open-telemetry/opentelemetry-js/tree/main/doc.
Which problem is this PR solving?
After reading the discussion on #3847 and consulting other maintainers, I thought it would be good to write dependency guidelines.
Short description of the changes
Add GUIDELINES.md file. Currently contain only dependency guidelines.