refactor(pluginloader): move internalFilesList #401
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markwolff
commented
Oct 3, 2019
| @@ -79,10 +110,27 @@ export class PluginLoader { | |||
| } | |||
|
|
|||
| // Enable the require hook. | |||
| hook(modulesToHook, (exports, name, baseDir) => { | |||
| hook(modulesToHook, { internals: true }, (exports, name, baseDir) => { | |||
There was a problem hiding this comment.
This is the new entry point into the internal stuff. It causes this to function to trigger for every internal file loaded in the module. This is probably not good for perf even though the module is immediately returned as is when there is no patching to be done.
|
Closing this since it seems to be due to an issue with internalFilesLoader |
|
Does this suggest that we should move the Node-specific plugin config to a new package? I wonder if that would be useful given that the browser environment plugins will look a bit different per #405 |
lukaswelinder
pushed a commit
to agile-pm/opentelemetry-js
that referenced
this pull request
Jul 24, 2020
Signed-off-by: Yuri Shkuro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
Draft PR for initial attempt at moving
internalFilesListstuff to PluginLoader. Tests currently won't pass unless you provide absolute path to the grpc plugin ingrpc.tests.tsdue to #368.