-
Notifications
You must be signed in to change notification settings - Fork 814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(sdk-node): deprecate methods in favor of constructor options #3996
Merged
pichlermarc
merged 13 commits into
open-telemetry:main
from
dynatrace-oss-contrib:chore/deprecate-sdk-node-methods
Aug 16, 2023
Merged
chore(sdk-node): deprecate methods in favor of constructor options #3996
pichlermarc
merged 13 commits into
open-telemetry:main
from
dynatrace-oss-contrib:chore/deprecate-sdk-node-methods
Aug 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pichlermarc
changed the title
chore(sdk-node): deprecate methods that duplicate constructor options
chore(sdk-node): deprecate methods in favor of constructor options
Jul 14, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3996 +/- ##
==========================================
- Coverage 92.37% 90.52% -1.86%
==========================================
Files 321 159 -162
Lines 9273 3756 -5517
Branches 1970 835 -1135
==========================================
- Hits 8566 3400 -5166
+ Misses 707 356 -351 |
…ccidentally published with 0.41.1
pichlermarc
force-pushed
the
chore/deprecate-sdk-node-methods
branch
from
July 31, 2023 13:28
b282fdc
to
5d7a5b2
Compare
dyladan
approved these changes
Aug 9, 2023
MSNev
approved these changes
Aug 9, 2023
shashi3kiran3
added a commit
to shashi3kiran3/opentelemetry-js
that referenced
this pull request
Aug 17, 2023
dyladan
added a commit
that referenced
this pull request
Aug 23, 2023
…3996) (#4076) Co-authored-by: Daniel Dyla <[email protected]>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
As discussed in the SIG meeting, deprecating all methods in
NodeSDK
except forstart()
andshutdown()
as everything can be done in one place via the constructor. This will reduce our API surface and reduce complexity inNodeSDK
I'll open a follow-up PR to remove these methods in a later release
Short description of the changes
deprecate
NodeSDK.configureTracerProvider()
NodeSDK.configureLoggerProvider()
NodeSDK.configureMeterProvider()
NodeSDK.addResource()
NodeSDK.detectResources()
remove unreleased
NodeSDKconfigureLoggerProvider()
How Has This Been Tested?