-
Notifications
You must be signed in to change notification settings - Fork 832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: anchored clock #3134
feat: anchored clock #3134
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3134 +/- ##
=======================================
Coverage 93.28% 93.28%
=======================================
Files 201 202 +1
Lines 6579 6599 +20
Branches 1379 1384 +5
=======================================
+ Hits 6137 6156 +19
- Misses 442 443 +1
|
…into anchored-clock
Seems like browser tests are unhappy:
|
and thats why we have them |
i am getting these errors |
Hi @itai-codefresh, thanks for reporting this. Do you have a way to reproduce this issue? 🤔 |
At least instrumentation express provides a timestamp to See open-telemetry/opentelemetry-js-contrib#1209 and open-telemetry/opentelemetry-js-contrib#1193 |
Introduce an anchored clock which is resistant to time drift. Create a single anchored clock instance per local trace and store the anchored clocks in a weak map on the tracer to ensure they don't memory leak.