-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: unifying shutdown once with BindOnceFuture #2695
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2695 +/- ##
==========================================
+ Coverage 92.57% 92.82% +0.25%
==========================================
Files 151 153 +2
Lines 5277 5267 -10
Branches 1116 1112 -4
==========================================
+ Hits 4885 4889 +4
+ Misses 392 378 -14
|
5fac72e
to
76edc67
Compare
76edc67
to
b36a1a2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! This will definitely be useful in other places as well. 💯
…2695) Co-authored-by: Valentin Marchaud <[email protected]>
Added breaking label late here. It's breaking because
Actually not that an issue as it happened before 1.x was made. |
@Flarna we can add the flag back. Didn't notice it is a protected property rather than a private property. |
@legendecas That was not my intention here. It's just about getting it correct into the next release notes/changelog. It happens before 1.x as released so the perfect timing. |
Which problem is this PR solving?
The procedure of shutdown once is implemented at several places. It may be good to have them all to share an abstract BindOnce structure.
Type of change
Checklist: