refactor(http-plugin): use SpanProcessor for tests #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove TracerTest Remove SpanAuditProcessor Closes open-telemetry#209 Signed-off-by: Olivier Albertini <[email protected]>
OlivierAlbertini
requested review from
bg451,
danielkhan,
iredelmeier,
mayurkale22 and
rochdev
as code owners
Codecov Report
@@ Coverage Diff @@
## master #244 +/- ##
==========================================
+ Coverage 98.93% 98.94% +0.01%
==========================================
Files 67 67
Lines 2536 2663 +127
Branches 154 174 +20
==========================================
+ Hits 2509 2635 +126
- Misses 27 28 +1
|
mayurkale22
reviewed
Sep 10, 2019
packages/opentelemetry-plugin-http/test/functionals/http-enable.test.ts
Outdated
Show resolved
Hide resolved
packages/opentelemetry-plugin-http/test/functionals/http-enable.test.ts
Outdated
Show resolved
Hide resolved
packages/opentelemetry-plugin-http/test/functionals/http-package.test.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Olivier Albertini <[email protected]>
markwolff
approved these changes
Sep 10, 2019
|
I will handle the docs issue in separate PR, merging this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Simplify tests
Closes #209
Short description of the changes
Signed-off-by: Olivier Albertini [email protected]