Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: tag more reviewers #230

Merged
merged 2 commits into from
Aug 30, 2019

Conversation

mayurkale22
Copy link
Member

Which problem is this PR solving?

  • Tag more reviewers

@mayurkale22
Copy link
Member Author

@OlivierAlbertini @vmarchaud @markwolff I hope you are ok with this, otherwise let me know.

@mayurkale22 mayurkale22 requested a review from bg451 August 29, 2019 18:48
@codecov-io
Copy link

codecov-io commented Aug 29, 2019

Codecov Report

Merging #230 into master will increase coverage by 2.88%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #230      +/-   ##
==========================================
+ Coverage   79.77%   82.65%   +2.88%     
==========================================
  Files          50       52       +2     
  Lines        1498     1776     +278     
  Branches      114      125      +11     
==========================================
+ Hits         1195     1468     +273     
- Misses        303      308       +5
Impacted Files Coverage Δ
...telemetry-node-tracer/src/instrumentation/utils.ts 95.83% <0%> (-4.17%) ⬇️
...ges/opentelemetry-core/src/common/ConsoleLogger.ts 91.66% <0%> (-1.67%) ⬇️
...s/opentelemetry-core/test/trace/tracestate.test.ts 100% <0%> (ø) ⬆️
...entelemetry-core/test/common/ConsoleLogger.test.ts 100% <0%> (ø) ⬆️
...metry-node-tracer/src/instrumentation/constants.ts 100% <0%> (ø) ⬆️
.../opentelemetry-core/src/trace/spancontext-utils.ts 100% <0%> (ø) ⬆️
...s/opentelemetry-core/test/trace/NoopTracer.test.ts 100% <0%> (ø) ⬆️
...try-node-tracer/test/instrumentation/utils.test.ts 100% <0%> (ø) ⬆️
...ckages/opentelemetry-core/test/platform/id.test.ts 100% <0%> (ø) ⬆️
...pentelemetry-core/test/internal/validators.test.ts 100% <0%> (ø) ⬆️
... and 15 more

Copy link
Contributor

@danielkhan danielkhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mayurkale22 mayurkale22 merged commit 24d2927 into open-telemetry:master Aug 30, 2019
@mayurkale22 mayurkale22 deleted the more_reviewers branch August 30, 2019 15:17
dyladan pushed a commit to dyladan/opentelemetry-js that referenced this pull request Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants