Add CODEOWNERS #16
Add CODEOWNERS #16
Conversation
.github/CODEOWNERS
Outdated
| # https://help.github.com/en/articles/about-code-owners | ||
| # | ||
|
|
||
| * @justindsmith @draffensperger @iredelmeier @yurishkuro @danielkhan @mayurkale22 |
There was a problem hiding this comment.
draffensperger is not in the list: https://github.com/open-telemetry/community/blob/master/community-members.md#nodejs
I don't mind as long as you and bogdan are ok. Just make sure to nominate him in community repo
There was a problem hiding this comment.
I will chat with @mayurkale22 more about my involvement in this tomorrow and should be able to give more clarity soon.
There was a problem hiding this comment.
I chatted with Mayur today and I'd rather not be added as an approver at this point, because I won't be an active contributor of code to the project and because Mayur already is an involved maintainer from Google for this project.
My interest is primarily around making sure that the library will be compatible with the browser platform (and adding browser instrumentation over time as a side project based on the opencensus-web code). I think I can have that influence through code and design reviews without needing to be an official approver.
There was a problem hiding this comment.
Updated the PR accordingly. PTAL
* Add CODEOWNERS * Add CODEOWNERS * rename @draffensperger
Based on https://github.com/open-telemetry/community/blob/d0765b2eff989503700bfab9dc9602fbc46809d5/community-members.md#nodejs