Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add dependencies badge #135

Merged
merged 2 commits into from
Jul 29, 2019

Conversation

mayurkale22
Copy link
Member

Updates #96

example:
Screen Shot 2019-07-25 at 3 41 07 PM

@codecov-io
Copy link

Codecov Report

Merging #135 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #135   +/-   ##
=======================================
  Coverage   98.74%   98.74%           
=======================================
  Files          29       29           
  Lines        1915     1915           
  Branches      221      221           
=======================================
  Hits         1891     1891           
  Misses         24       24
Impacted Files Coverage Δ
...kages/opentelemetry-scope-async-hooks/src/index.ts 100% <0%> (ø) ⬆️
packages/opentelemetry-scope-base/src/index.ts 100% <0%> (ø) ⬆️
packages/opentelemetry-scope-base/src/types.ts 100% <0%> (ø) ⬆️
...ry-scope-async-hooks/src/AsyncHooksScopeManager.ts 96.49% <0%> (ø) ⬆️
...s/opentelemetry-scope-base/src/NoopScopeManager.ts 100% <0%> (ø) ⬆️

2 similar comments
@codecov-io
Copy link

Codecov Report

Merging #135 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #135   +/-   ##
=======================================
  Coverage   98.74%   98.74%           
=======================================
  Files          29       29           
  Lines        1915     1915           
  Branches      221      221           
=======================================
  Hits         1891     1891           
  Misses         24       24
Impacted Files Coverage Δ
...kages/opentelemetry-scope-async-hooks/src/index.ts 100% <0%> (ø) ⬆️
packages/opentelemetry-scope-base/src/index.ts 100% <0%> (ø) ⬆️
packages/opentelemetry-scope-base/src/types.ts 100% <0%> (ø) ⬆️
...ry-scope-async-hooks/src/AsyncHooksScopeManager.ts 96.49% <0%> (ø) ⬆️
...s/opentelemetry-scope-base/src/NoopScopeManager.ts 100% <0%> (ø) ⬆️

@codecov-io
Copy link

Codecov Report

Merging #135 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #135   +/-   ##
=======================================
  Coverage   98.74%   98.74%           
=======================================
  Files          29       29           
  Lines        1915     1915           
  Branches      221      221           
=======================================
  Hits         1891     1891           
  Misses         24       24
Impacted Files Coverage Δ
...kages/opentelemetry-scope-async-hooks/src/index.ts 100% <0%> (ø) ⬆️
packages/opentelemetry-scope-base/src/index.ts 100% <0%> (ø) ⬆️
packages/opentelemetry-scope-base/src/types.ts 100% <0%> (ø) ⬆️
...ry-scope-async-hooks/src/AsyncHooksScopeManager.ts 96.49% <0%> (ø) ⬆️
...s/opentelemetry-scope-base/src/NoopScopeManager.ts 100% <0%> (ø) ⬆️

@codecov-io
Copy link

codecov-io commented Jul 26, 2019

Codecov Report

Merging #135 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #135   +/-   ##
=======================================
  Coverage   98.74%   98.74%           
=======================================
  Files          29       29           
  Lines        1915     1915           
  Branches      221      221           
=======================================
  Hits         1891     1891           
  Misses         24       24

Copy link
Member

@rochdev rochdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Maybe eventually we should switch to something more robust like Greenkeeper which actually opens PR to update versions?

@mayurkale22
Copy link
Member Author

LGTM. Maybe eventually we should switch to something more robust like Greenkeeper which actually opens PR to update versions?

#11 is already opened to address this.

@mayurkale22 mayurkale22 merged commit 7db6e9b into open-telemetry:master Jul 29, 2019
@mayurkale22 mayurkale22 deleted the dependencies_badge branch July 29, 2019 16:49
dyladan pushed a commit to dyladan/opentelemetry-js that referenced this pull request Sep 9, 2022
dyladan pushed a commit to dyladan/opentelemetry-js that referenced this pull request Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants