Skeleton: Add automatic-tracer package #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayurkale22
requested review from
danielkhan,
iredelmeier,
justindsmith and
rochdev
as code owners
Codecov Report
@@ Coverage Diff @@
## master #107 +/- ##
=======================================
Coverage 98.61% 98.61%
=======================================
Files 26 26
Lines 1732 1732
Branches 193 193
=======================================
Hits 1708 1708
Misses 24 24 |
rochdev
reviewed
Jul 22, 2019
| @@ -0,0 +1,11 @@ | |||
| # `opentelemetry-automatic-tracer` | |||
There was a problem hiding this comment.
Does this mean to be called automatic tracer? I think just opentelemetry-tracer is fine since the user would expect such a tracer to just work out of the box, so automatic is redundant. This is especially true since the base tracer is called basic-tracer and not tracer.
There was a problem hiding this comment.
I am fine with the opentelemetry-tracer name, done.
mayurkale22
force-pushed
the
automatic-tracer
branch
from
a37d394 to
16d339f
Compare
rochdev
approved these changes
Jul 22, 2019
pichlermarc
pushed a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this pull request
Dec 15, 2023
… layer open-telemetry#107 (open-telemetry#188) * fix(express): listen for `finish` event on response for async express layer open-telemetry#107 * chore: address pr comments * fix: typo in comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates #91