Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(opentelemetry-plugin-xml-http-request): define span kind as CLIENT for xmlhttprequests #1002

Merged
merged 6 commits into from
May 1, 2020
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
lint fix
  • Loading branch information
ivansenic committed May 1, 2020
commit b13b01599b61232d6261ec2942cf968faba25f45
Original file line number Diff line number Diff line change
@@ -212,7 +212,11 @@ describe('xhr', () => {

it('span should have correct kind', () => {
const span: tracing.ReadableSpan = exportSpy.args[0][0][0];
assert.strictEqual(span.kind, types.SpanKind.CLIENT, 'span has wrong kind');
assert.strictEqual(
span.kind,
types.SpanKind.CLIENT,
'span has wrong kind'
);
});

it('span should have correct attributes', () => {