-
Notifications
You must be signed in to change notification settings - Fork 839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to create metrics with different aggregators #989
Labels
Comments
dyladan
added
the
up-for-grabs
Good for taking. Extra help will be provided by maintainers
label
Apr 28, 2020
dyladan
removed
the
up-for-grabs
Good for taking. Extra help will be provided by maintainers
label
Apr 29, 2020
Do we want to put those kind of documentation inside |
@vmarchaud example is cool but doc can still be useful. Another point is that I checked otel impl in go, Batcher in go can determine aggregator by MetricDescriptor but not MetricKind. I'm wondering if it's ok to port this API to js before we document the batcher API, since batcher (or maybe integrator) is not been in spec yet. |
vmarchaud
added a commit
to vmarchaud/opentelemetry-js
that referenced
this issue
May 3, 2020
mayurkale22
pushed a commit
that referenced
this issue
May 4, 2020
vmarchaud
added a commit
to vmarchaud/opentelemetry-js
that referenced
this issue
May 23, 2020
vmarchaud
added a commit
to vmarchaud/opentelemetry-js
that referenced
this issue
May 28, 2020
mayurkale22
added a commit
that referenced
this issue
May 28, 2020
* docs(batcher): document how to configure custom aggregators #989 * chore: address PR comments Co-authored-by: Mayur Kale <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
In the current API shape, it is not able to create a metric and set an expected aggregator. Like say, we have two observer metrics, one we'd like to aggregate with HistogramAggregator, and another with DistributionAggregator.
Describe the solution you'd like
Document the batcher API, or allow meters to accept an option of aggregation type on creating metrics.
The text was updated successfully, but these errors were encountered: