We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
From reading code, it looks like we require the traceparent version to be 00: https://github.com/open-telemetry/opentelemetry-js/blob/master/packages/opentelemetry-core/src/context/propagation/HttpTraceContext.ts#L30
00
The W3C spec says that we should still attempt to parse the known fields, as future extensions will be additive: https://www.w3.org/TR/trace-context/#versioning-of-traceparent
This should probably be fixed by allowing any 2-digit lower-case hex value except ff.
ff
While at it, we should also verify that we accept any additional data in the header, given that the first extra character is -.
-
Perhaps glance at the Go implementation, which has better compliance: https://github.com/open-telemetry/opentelemetry-go/blob/669d4b3a6c8d01821a65026f49df1b85d2972c14/api/trace/trace_context_propagator.go#L39
The text was updated successfully, but these errors were encountered:
Thanks for reporting this! Yes, you're right. We should replace 00 => [\da-f]{2} or something like this.
[\da-f]{2}
Sorry, something went wrong.
If you are feeling motivated, maybe you can attempt to write solution and open a PR.
I'll have a look once I get my C++ implementation solid. ..and I may have to open this issue against every language in Otel : /
fix: remove link to browser extension to external repo. (open-telemet…
c5b9356
…ry#979)
Successfully merging a pull request may close this issue.
From reading code, it looks like we require the traceparent version to be
00
:https://github.com/open-telemetry/opentelemetry-js/blob/master/packages/opentelemetry-core/src/context/propagation/HttpTraceContext.ts#L30
The W3C spec says that we should still attempt to parse the known fields, as future extensions will be additive:
https://www.w3.org/TR/trace-context/#versioning-of-traceparent
This should probably be fixed by allowing any 2-digit lower-case hex value except
ff
.While at it, we should also verify that we accept any additional data in the header, given that the first extra character is
-
.Perhaps glance at the Go implementation, which has better compliance: https://github.com/open-telemetry/opentelemetry-go/blob/669d4b3a6c8d01821a65026f49df1b85d2972c14/api/trace/trace_context_propagator.go#L39
The text was updated successfully, but these errors were encountered: