Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dom from node-only libs #936

Open
dyladan opened this issue Apr 7, 2020 · 1 comment
Open

Remove dom from node-only libs #936

dyladan opened this issue Apr 7, 2020 · 1 comment
Labels
feature-request

Comments

@dyladan
Copy link
Member

dyladan commented Apr 7, 2020 •
edited
Loading

As disussed here: #585 (comment)

We should remove the possibility of using dom globals in libs we know to be node-only by setting libs in tsconfig

From @Flarna in #585

Maybe the projects should be configured more strict. e.g. plugin-http is node only therefore lib dom should be not needed/used at all. As there is no lib config in tsconfig.json of the plugin-http nor in tsconfig.base.json typescript includes dom on default.
@Flarna Flarna mentioned this issue Feb 10, 2023
Open
@dyladan
Copy link
Member Author

dyladan commented Jun 21, 2023 •
edited
Loading

I'm not sure this would help since several packages like api and core which are required to use otel at all would pull the dom types in.

pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this issue Dec 15, 2023
@rauno56
feat: loosen up peer api check to require dev ver to satisfy peer ver (…
3ad1727 
…open-telemetry#936)

* feat: loosen up peer api check to require dev ver to satisfy peer ver
* fix: install semver locally in scripts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dyladan