-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for jaeger propagation formats #696
Comments
If I understand correctly, you can do it like:
|
HttpTextFormat interface is just an interface that your formatter must conform to. There is a text format and a binary format interface. You should implement the text format interface. I think @OlivierAlbertini was referring to the |
I removed the target label because this could be used for both web and node. |
We can re-use code from OpenCensus: https://github.com/census-instrumentation/opencensus-node/tree/master/packages/opencensus-propagation-jaeger |
@vladislav-kiva are you implementing this? |
@dyladan He wrote on the node gitter that he started to work on that, hence i assigned it to him |
@dyladan yeap for now i already wrote it and now i'm writing tests| |
@mayurkale22 thanks i will take a look on it, for now i was using https://github.com/jaegertracing/jaeger-client-node |
* feat: add jaeger http trace format (#696) * feat: add jaeger http trace format (#696) * feat: add jaeger http trace format (#696) * feat: add jaeger http trace format (#696) * feat: add jaeger http trace format (#696) * feat: add jaeger http trace format (#696) * fix: we should set sampled\unsampled via flag * fix: we should set sampled\unsampled via flag * fix: flags should be converted to hex, not decimal * feat: create new package for propagation jaeger * fix: remove unused dependencies, correct readme header, moved out jaeger from core index.ts * fix: added jaeger keyword * fix: remove comma * docs: replace NodeTracer with NodeTracerRegistry * fix: added missing jaeger keyword to exporter-jaeger * fix: remove test for browser * fix: remove yarn for browser * fix: use same naming style as other packages * feat: added index.ts and version.ts, revert test for browser * fix: tests added index-webpack.ts * test: add test with span generated by jaeger client * fix: apply review changes * fix: move out from sub dirs * docs: use common language for docs * fix: test script fix Co-authored-by: Uladzislau Kiva <[email protected]>
…ry#701) * feat: add jaeger http trace format (open-telemetry#696) * feat: add jaeger http trace format (open-telemetry#696) * feat: add jaeger http trace format (open-telemetry#696) * feat: add jaeger http trace format (open-telemetry#696) * feat: add jaeger http trace format (open-telemetry#696) * feat: add jaeger http trace format (open-telemetry#696) * fix: we should set sampled\unsampled via flag * fix: we should set sampled\unsampled via flag * fix: flags should be converted to hex, not decimal * feat: create new package for propagation jaeger * fix: remove unused dependencies, correct readme header, moved out jaeger from core index.ts * fix: added jaeger keyword * fix: remove comma * docs: replace NodeTracer with NodeTracerRegistry * fix: added missing jaeger keyword to exporter-jaeger * fix: remove test for browser * fix: remove yarn for browser * fix: use same naming style as other packages * feat: added index.ts and version.ts, revert test for browser * fix: tests added index-webpack.ts * test: add test with span generated by jaeger client * fix: apply review changes * fix: move out from sub dirs * docs: use common language for docs * fix: test script fix Co-authored-by: Uladzislau Kiva <[email protected]>
Is your feature request related to a problem? Please describe.
Problem: In our company we have an existing ecosystem of around 50 microservices per domain. Practically all instrumented with existing jaeger libraries and they are using jaeger standards like
uber-trace-id
HTTP header and so on.Describe the solution you'd like
I think we should implement smth like JaegerHttpTraceFormat.ts near B3Format.ts and HttpTraceContext.ts. That would allow us to work with jaeger format's and we can switch between formats via configuration
The text was updated successfully, but these errors were encountered: