Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Centralize test utility functions and assertions #617

Closed
dyladan opened this issue Dec 13, 2019 · 2 comments
Closed

Centralize test utility functions and assertions #617

dyladan opened this issue Dec 13, 2019 · 2 comments
Assignees
@naseemkullah
Labels
enhancement New feature or request

Comments

@dyladan
Copy link
Member

dyladan commented Dec 13, 2019

There are several utility functions and assertions such as assertSpan that are duplicated in the tests of several of our packages.

Create a new private lerna package named @opentelemetry/test-utils that would be a dev dependency of our packages and provide these helper functions.
@dyladan dyladan added good first issue Good for newcomers up-for-grabs Good for taking. Extra help will be provided by maintainers labels Dec 13, 2019
@dyladan dyladan mentioned this issue Dec 13, 2019
Merged
@mayurkale22 mayurkale22 added the enhancement New feature or request label Dec 13, 2019
@OlivierAlbertini OlivierAlbertini changed the title Centralize test utility funcitions and assertions Centralize test utility functions and assertions Dec 13, 2019
@naseemkullah naseemkullah mentioned this issue Dec 22, 2019
Merged
@naseemkullah
Copy link
Member

🙋‍♂

@vmarchaud vmarchaud removed good first issue Good for newcomers up-for-grabs Good for taking. Extra help will be provided by maintainers labels Dec 22, 2019
@mayurkale22
Copy link
Member

@dyladan @naseemkullah Can we close this one via #644?

@dyladan dyladan closed this as completed Jan 3, 2020
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this issue Dec 15, 2023
@renovate-bot
chore(deps): pin dependencies (open-telemetry#617)
5e04284
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@naseemkullah naseemkullah

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dyladan @vmarchaud @mayurkale22 @naseemkullah