Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linting "/examples" #603

Closed
obecny opened this issue Dec 10, 2019 · 3 comments · Fixed by #649
Closed

Linting "/examples" #603

obecny opened this issue Dec 10, 2019 · 3 comments · Fixed by #649
Assignees
@naseemkullah
Labels
enhancement New feature or request

Comments

@obecny
Copy link
Member

obecny commented Dec 10, 2019

Should we enforce some lint rules on examples that could be automatically validated, as now we don't have it.
@obecny obecny added the Discussion Issue or PR that needs/is extended discussion. label Dec 10, 2019
@obecny obecny changed the title Linting examples Linting "/examples" Dec 10, 2019
@mayurkale22
Copy link
Member

Good idea, I used semistandard before.

@mayurkale22 mayurkale22 added the up-for-grabs Good for taking. Extra help will be provided by maintainers label Dec 18, 2019
@naseemkullah
Copy link
Member

🙋‍♂

@naseemkullah
Copy link
Member

I can take this, I will be going with the airbnb linter as it is the most popular as per https://www.npmtrends.com/eslint-config-airbnb-vs-eslint-config-google-vs-eslint-config-standard-vs-eslint-config-airbnb-base-vs-eslint-config-recommended-vs-eslint-config-semistandard-vs-eslint-config-transit

@naseemkullah naseemkullah mentioned this issue Dec 26, 2019
Merged
@dyladan dyladan added enhancement New feature or request and removed Discussion Issue or PR that needs/is extended discussion. up-for-grabs Good for taking. Extra help will be provided by maintainers labels Dec 26, 2019
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this issue Dec 15, 2023
@NathanielRN @dyladan
Replace 55681 endpoint with 4318 endpoint for HTTP collector (open-te…
4de977e 
…lemetry#603)

Co-authored-by: Daniel Dyla <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@naseemkullah naseemkullah

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: lint examples naseemkullah/opentelemetry-js
4 participants
@obecny @dyladan @mayurkale22 @naseemkullah