Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect constructor typing for http/proto OTLPLogExporter #5057

Closed
raphael-theriault-swi opened this issue Oct 9, 2024 · 0 comments · Fixed by #5058
Closed

Incorrect constructor typing for http/proto OTLPLogExporter #5057

raphael-theriault-swi opened this issue Oct 9, 2024 · 0 comments · Fixed by #5058
Labels
bug Something isn't working triage

Comments

@raphael-theriault-swi
Copy link
Contributor

What happened?

Steps to Reproduce

Try to pass an OTLPExporterNodeConfigBase to the OTLPLogExporter from exporter-logs-otlp-proto.

Expected Result

Typechecks.

Actual Result

Does not typecheck.

Additional Details

https://github.com/open-telemetry/opentelemetry-js/blob/v1.26.0/experimental/packages/exporter-logs-otlp-proto/src/platform/node/OTLPLogExporter.ts#L47

OpenTelemetry Setup Code

No response

package.json

No response

Relevant log output

No response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working triage
Projects
None yet
Milestone
No milestone
1 participant
@raphael-theriault-swi